PrestaShop: Quantity Discounts Fix

In PrestaShop 1.3 Quantity Discounts do not work properly – currently they only work correctly for percentage discounts and with a Tax assigned to the product which “correct” the final price so everything looks almost fine. However in fact it doesn’t in certain cases.

Note: We’ve previously posted this fix at prestashop.com: [Fix] Quantity Discounts do not work properly (BUGS 6792 & 6827)

The reason why it does not work is basically due to the design of code located in classes/PaymentModule.php file:

$reduc = QuantityDiscount::getValue($price_wt, $qtyD->id_discount_type, $qtyD->value, new Currency(intval($order->id_currency)));

This code INCORRECTLY computes quantity discount amount for product_quantity_discount field in order_details table, because it computes the discount from price ($price_wt variable) to which was Quantity Discount already applied (also Group Reduction was applied what is wrong as well).

The problem with “Quantity Discount already applied” can easily be solved by getting the price of product by calling Product::getPriceStatic() method with 1 quantity of product (currently it uses variable with price computed for multiple products).
The problem with “Group Reduction already applied” has to be solved by adding a new argument to Product::getPriceStatic() method.

Let’s fix it.

Find:

$reduc = QuantityDiscount::getValue($price_wt, $qtyD->id_discount_type, $qtyD->value, new Currency(intval($order->id_currency)));

Replace with:

$price_wt_no_qtyD = Product::getPriceStatic(intval($product['id_product']), true, ($product['id_product_attribute'] ? intval($product['id_product_attribute']) : NULL), 6, NULL, false, true, 1, false, NULL, NULL, NULL, false);
$reduc = QuantityDiscount::getValue($price_wt_no_qtyD, $qtyD->id_discount_type, $qtyD->value, ($tax) ? true : false, $tax, $currency);

This fixes the price inserted to product_price field in order_details table which needs to be pure price without any reductions applied:

Find:

'.floatval(Product::getPriceStatic(intval($product['id_product']), false, ($product['id_product_attribute'] ? intval($product['id_product_attribute']) : NULL), (Product::getTaxCalculationMethod(intval($order->id_customer)) == PS_TAX_EXC ? 2 : 6), NULL, false, false, $product['cart_quantity'], false, intval($order->id_customer), intval($order->id_cart), intval($order->id_address_delivery))).',

Replace with:

'.floatval(Product::getPriceStatic(intval($product['id_product']), false, ($product['id_product_attribute'] ? intval($product['id_product_attribute']) : NULL), (Product::getTaxCalculationMethod(intval($order->id_customer)) == PS_TAX_EXC ? 2 : 6), NULL, false, false, 1, false, intval($order->id_customer), intval($order->id_cart), intval($order->id_address_delivery))).',

This fixes strange warning (not required):

.(int)QuantityDiscount::getDiscountFromQuantity(intval($product['id_product']), intval($product['cart_quantity'])).',

Replace with:

'.((!QuantityDiscount::getDiscountFromQuantity(intval($product['id_product']), intval($product['cart_quantity']))) ? '0' : '1').',

Now we will add a new argument to Product::getPriceStatic() method in classes/Product.php file:
(to be able to get price without Group Reduction discount applied – this fix does not change the behavior of this method which means any old code will work exactly the same as before).

Find:

public static function getPriceStatic($id_product, $usetax = true, $id_product_attribute = NULL, $decimals = 6, $divisor = NULL, $only_reduc = false, $usereduc = true, $quantity = 1, $forceAssociatedTax = false, $id_customer = NULL, $id_cart = NULL, $id_address_delivery = NULL)

Replace with:

public static function getPriceStatic($id_product, $usetax = true, $id_product_attribute = NULL, $decimals = 6, $divisor = NULL, $only_reduc = false, $usereduc = true, $quantity = 1, $forceAssociatedTax = false, $id_customer = NULL, $id_cart = NULL, $id_address_delivery = NULL, $group_reduc = true)

Find:

if ($usereduc)
	$price -= Tools::ps_round($price * Group::getReduction(((isset($id_customer) AND $id_customer) ? $id_customer : 0)) / 100, 2);

Replace with:

if ($usereduc && $group_reduc)
	$price -= Tools::ps_round($price * Group::getReduction(((isset($id_customer) AND $id_customer) ? $id_customer : 0)) / 100, 2);

Find:

$cacheId = $id_product.'-'.($usetax?'1':'0').'-'.$id_product_attribute.'-'.$decimals.'-'.$divisor.'-'.($only_reduc?'1':'0').'-'.($usereduc?'1':'0').'-'.$quantity.'-'.($id_customer ? $id_customer : '0');

Replace with:

$cacheId = $id_product.'-'.($usetax?'1':'0').'-'.$id_product_attribute.'-'.$decimals.'-'.$divisor.'-'.($only_reduc?'1':'0').'-'.($usereduc?'1':'0').'-'.($group_reduc?'1':'0').'-'.$quantity.'-'.($id_customer ? $id_customer : '0');

From now on all records are inserted to the database with correct values and the only last two issues needs to be corrected: Order::_deleteProduct() and Order::setProductPrices() methods in classes/Order.php file.

Open classes/Order.php file and replace the entire Order::setProductPrices() method with the following code:

public function setProductPrices(&$row)
{
	if ($this->_taxCalculationMethod == PS_TAX_EXC)
		$row['product_price'] = Tools::ps_round($row['product_price'], 2);
	else
		$row['product_price_wt'] = Tools::ps_round($row['product_price'] * (1 + $row['tax_rate'] / 100), 2);
	if ($row['reduction_percent'])
	{
		if ($this->_taxCalculationMethod == PS_TAX_EXC)
			$row['product_price'] = $row['product_price'] - $row['product_price'] * ($row['reduction_percent'] * 0.01);
		else
			$row['product_price_wt'] = Tools::ps_round($row['product_price_wt'] - $row['product_price_wt'] * ($row['reduction_percent'] * 0.01), 2);
	}
	if ($row['reduction_amount'])
	{
		if ($this->_taxCalculationMethod == PS_TAX_EXC)
			$row['product_price'] = $row['product_price'] - $row['reduction_amount'];
		else
			$row['product_price_wt'] = Tools::ps_round($row['product_price_wt'] - $row['reduction_amount'] * (1 + ($row['tax_rate'] * 0.01)), 2);
	}

	if ($row['group_reduction'])
	{
		if ($this->_taxCalculationMethod == PS_TAX_EXC)
			$row['product_price'] = $row['product_price'] - $row['product_price'] * ($row['group_reduction'] * 0.01);
		else
			$row['product_price_wt'] = Tools::ps_round($row['product_price_wt'] - $row['product_price_wt'] * ($row['group_reduction'] * 0.01), 2);
	}
	if (($row['reduction_percent'] OR $row['reduction_amount'] OR $row['group_reduction']) AND $this->_taxCalculationMethod == PS_TAX_EXC)
		$row['product_price'] = Tools::ps_round($row['product_price'], 2);

	if ($this->_taxCalculationMethod == PS_TAX_EXC)
		$row['product_price_wt'] = Tools::ps_round($row['product_price'] * (1 + ($row['tax_rate'] * 0.01)), 2) + Tools::ps_round($row['ecotax'] * (1 + $row['ecotax_tax_rate'] / 100), 2);
	else
	{
		$row['product_price_wt_but_ecotax'] = $row['product_price_wt'];
		$row['product_price_wt'] = Tools::ps_round($row['product_price_wt'] + $row['ecotax'] * (1 + $row['ecotax_tax_rate'] / 100), 2);
	}
	$row['total_wt'] = $row['product_quantity'] * $row['product_price_wt'];
	$row['total_price'] = $row['product_quantity'] * $row['product_price_wt'];
}

Replace with:

public function setProductPrices(&$row)
{
	if ($this->_taxCalculationMethod == PS_TAX_EXC)
		$row['product_price'] = Tools::ps_round($row['product_price'], 2);
	else
		$row['product_price_wt'] = Tools::ps_round($row['product_price'] * (1 + $row['tax_rate'] / 100), 2);
	if ($row['reduction_percent'])
	{
		if ($this->_taxCalculationMethod == PS_TAX_EXC)
			$row['product_price'] = $row['product_price'] - $row['product_price'] * ($row['reduction_percent'] * 0.01);
		else
			$row['product_price_wt'] = Tools::ps_round($row['product_price_wt'] - $row['product_price_wt'] * ($row['reduction_percent'] * 0.01), 2);
	}
	if ($row['reduction_amount'])
	{
		if ($this->_taxCalculationMethod == PS_TAX_EXC)
			$row['product_price'] = $row['product_price'] - $row['reduction_amount'];
		else
			$row['product_price_wt'] = Tools::ps_round($row['product_price_wt'] - $row['reduction_amount'] * (1 + ($row['tax_rate'] * 0.01)), 2);
	}

	// Added - makes Qty discounts work properly - BEGIN
	if ($row['product_quantity_discount'])
	{
		if ($this->_taxCalculationMethod == PS_TAX_EXC)
			$row['product_price'] = Tools::ps_round($row['product_price'] - $row['product_quantity_discount'] / (1 + ($row['tax_rate'] * 0.01)), 2);
		else
			$row['product_price_wt'] = $row['product_price_wt'] - $row['product_quantity_discount'];
	}
	// Added - makes Qty discounts work properly - END

	if ($row['group_reduction'])
	{
		if ($this->_taxCalculationMethod == PS_TAX_EXC)
			$row['product_price'] = $row['product_price'] - $row['product_price'] * ($row['group_reduction'] * 0.01);
		else
			$row['product_price_wt'] = Tools::ps_round($row['product_price_wt'] - $row['product_price_wt'] * ($row['group_reduction'] * 0.01), 2);
	}
	if (($row['reduction_percent'] OR $row['reduction_amount'] OR $row['group_reduction']) AND $this->_taxCalculationMethod == PS_TAX_EXC)
		$row['product_price'] = Tools::ps_round($row['product_price'], 2);
	// Added - makes Qty discounts work properly - BEGIN
	if($row['product_quantity_discount'] AND $this->_taxCalculationMethod == PS_TAX_INC)
		$row['product_price'] = Tools::ps_round($row['product_price'], 2);
	// Added - makes Qty discounts work properly - END
	if ($this->_taxCalculationMethod == PS_TAX_EXC)
		$row['product_price_wt'] = Tools::ps_round($row['product_price'] * (1 + ($row['tax_rate'] * 0.01)), 2) + Tools::ps_round($row['ecotax'] * (1 + $row['ecotax_tax_rate'] / 100), 2);
	else
	{
		$row['product_price_wt_but_ecotax'] = $row['product_price_wt'];
		$row['product_price_wt'] = Tools::ps_round($row['product_price_wt'] + $row['ecotax'] * (1 + $row['ecotax_tax_rate'] / 100), 2);
	}
	$row['total_wt'] = $row['product_quantity'] * $row['product_price_wt'];
	$row['total_price'] = $row['product_quantity'] * $row['product_price_wt'];
}

Open classes/Order.php file and replace the entire Order::_deleteProduct() method with the following code:

private function _deleteProduct($orderDetail, $quantity)
{
	$row = Db::getInstance()->getRow('
					SELECT *
					FROM `'._DB_PREFIX_.'order_detail` od
					WHERE od.`id_order_detail` = '.intval($orderDetail->id));
	$this->setProductPrices($row);

	/* Update cart */
	$cart = new Cart($this->id_cart);
	$cart->updateQty($quantity, $orderDetail->product_id, $orderDetail->product_attribute_id, false, 'down'); // customization are deleted in deleteCustomization
	$cart->update();
	
	/* Update order */
	$shippingDiff = $this->total_shipping - $cart->getOrderShippingCost();
	$price = $row['product_price_wt'] * $quantity;
	$this->total_products -= $row['product_price'] * $quantity;
	$this->total_products_wt -= $row['product_price_wt'] * $quantity;
	$this->total_shipping = $cart->getOrderShippingCost();
	$this->total_paid -= ($price + $shippingDiff);
	$this->total_paid_real -= ($price + $shippingDiff);
	
	/* Prevent from floating precision issues (total_products has only 2 decimals) */
	if ($this->total_products < 0)
		$this->total_products = 0;
		
	/* Prevent from floating precision issues */
	$this->total_paid = number_format($this->total_paid, 2, '.', '');
	$this->total_paid_real = number_format($this->total_paid_real, 2, '.', '');
	$this->total_products = number_format($this->total_products, 2, '.', '');
	$this->total_products_wt = number_format($this->total_products_wt, 2, '.', '');

	/* Update order detail */
	$orderDetail->product_quantity -= intval($quantity);
	
	if (!$orderDetail->product_quantity)
	{
		if (!$orderDetail->delete())
			return false;
		if (count($this->getProductsDetail()) == 0)
		{
			global $cookie;
			$history = new OrderHistory();
			$history->id_order = intval($this->id);
			$history->changeIdOrderState(_PS_OS_CANCELED_, intval($this->id));
			if (!$history->addWithemail())
				return false;
		}
		return $this->update();
	}
	return $orderDetail->update() AND $this->update();
}

That’s all. Now Quantity Discounts in PrestaShop 1.3 start to work properly 🙂

Leave a Reply

Your email address will not be published. Required fields are marked *

Cart  
(empty)

Cart Check out  »

Prices are tax inclusive.

The VAT rate for your country (US) * is 0,0 % because it is not a member of the European Union (EU).

* Please create an account if your country does not match.

Community feed
  • [WP2PS] Yoast SEO plugin
    Thanks for your support installing the PS-WP integration. However there is some errors when PS-WP integration is activated. 1. Error generating sitemap with Yoas SEO plugin (it disappears when...
    by argidomin
  • [Zen Cart] How to exclude words from URLs
    I'd like to know if it's possible to configure some stop words (in italian language) to remove from SEO URL. Thanks
    by incircolo
  • [PrestaShop] Setting-up CDN
    Hi, the url that generates is this: Code: <link href="//static1.peplogar.com/modules/psaccelerator/cache/961263a2bac53db414c080690bc69cfd.css" rel="stylesheet"...
    by PepLogar
  • [PrestaShop] Theme Provider + jQuery
    Hello, I use your module with many websites, I have only one issue : As soon as I activate the option to put the javascript in the footer in Prestashop every jQuery widget or plugin used in the...
    by Akrolab
  • [phpBB] Issue with Activation
    Hi, I just bought the SEO Magic Url Plugin for phpbb 3.2 I am having issue with activation. I have the php 7 install in my site/server. Read me file says its 5.6 , do i need the 5.6 or it...
    by pornera
Join our support forum » Pre-Sales Questions »
Featured Testimonials

Magic SEO URLs for osCommerce are amazing product, helps my site a lot with SEO. The biggest advance of Magic SEO URLs is excellent service support. I know what I'm talking about because I had already bought web software from about 10 different companies. Magic SEO URLs is the best one. Keep the quality of the product and service and...

Jacek, the owner of Agro-Modele.pl

AWESOME! Worked like a charm. I now understand why you used the word Magic in its name. Quick, easy, painless, gets the job done, and beautiful. Thanks a Million for creating this fantastic tool and for the quick excellent support.

Mohammad, the owner of TradersCity

More Testimonials »